From f091c5d510e8274157af0a0ba02bfea968413120 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Wed, 3 Jun 2020 19:05:36 +0300 Subject: [PATCH] Dropdown.js: return early (#2783) --- build/js/Dropdown.js | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/build/js/Dropdown.js b/build/js/Dropdown.js index 563ebfe6b..344de8030 100644 --- a/build/js/Dropdown.js +++ b/build/js/Dropdown.js @@ -58,26 +58,28 @@ class Dropdown { fixPosition() { const $element = $(Selector.DROPDOWN_MENU_ACTIVE) - if ($element.length !== 0) { - if ($element.hasClass(ClassName.DROPDOWN_RIGHT)) { - $element.css('left', 'inherit') - $element.css('right', 0) - } else { - $element.css('left', 0) - $element.css('right', 'inherit') - } + if ($element.length === 0) { + return + } - const offset = $element.offset() - const width = $element.width() - const visiblePart = $(window).width() - offset.left + if ($element.hasClass(ClassName.DROPDOWN_RIGHT)) { + $element.css('left', 'inherit') + $element.css('right', 0) + } else { + $element.css('left', 0) + $element.css('right', 'inherit') + } - if (offset.left < 0) { - $element.css('left', 'inherit') - $element.css('right', (offset.left - 5)) - } else if (visiblePart < width) { - $element.css('left', 'inherit') - $element.css('right', 0) - } + const offset = $element.offset() + const width = $element.width() + const visiblePart = $(window).width() - offset.left + + if (offset.left < 0) { + $element.css('left', 'inherit') + $element.css('right', (offset.left - 5)) + } else if (visiblePart < width) { + $element.css('left', 'inherit') + $element.css('right', 0) } }