Merge pull request #155 from CJackHwang/codex/review-and-fix-pr-#153-issues

Sync tool-call compat fixtures and update node test to match permissive tool-call policy

tests/compat/expected/toolcalls_allowlist_empty.json

@@ -1,8 +1,13 @@
 {
-  "calls": [],
+  "calls": [
+    {
+      "name": "unknown_tool",
+      "input": {
+        "x": 1
+      }
+    }
+  ],
   "sawToolCallSyntax": true,
-  "rejectedByPolicy": true,
-  "rejectedToolNames": [
-    "unknown_tool"
-  ]
-}
+  "rejectedByPolicy": false,
+  "rejectedToolNames": []
+}

tests/compat/expected/toolcalls_case_insensitive_canonical.json

@@ -1,7 +1,7 @@
 {
   "calls": [
     {
-      "name": "read_file",
+      "name": "Read_File",
       "input": {
         "path": "README.MD"
       }
@@ -10,4 +10,4 @@
   "sawToolCallSyntax": true,
   "rejectedByPolicy": false,
   "rejectedToolNames": []
-}
+}

tests/compat/expected/toolcalls_loose_normalize.json

@@ -1,7 +1,7 @@
 {
   "calls": [
     {
-      "name": "read_file",
+      "name": "read-file",
       "input": {
         "path": "README.MD"
       }
@@ -10,4 +10,4 @@
   "sawToolCallSyntax": true,
   "rejectedByPolicy": false,
   "rejectedToolNames": []
-}
+}

tests/compat/expected/toolcalls_namespace_tail_normalize.json

@@ -1,7 +1,7 @@
 {
   "calls": [
     {
-      "name": "read_file",
+      "name": "company.fs.read_file",
       "input": {
         "path": "README.MD"
       }
@@ -10,4 +10,4 @@
   "sawToolCallSyntax": true,
   "rejectedByPolicy": false,
   "rejectedToolNames": []
-}
+}

tests/compat/expected/toolcalls_unknown_name.json

@@ -1,8 +1,13 @@
 {
-  "calls": [],
+  "calls": [
+    {
+      "name": "unknown_tool",
+      "input": {
+        "x": 1
+      }
+    }
+  ],
   "sawToolCallSyntax": true,
-  "rejectedByPolicy": true,
-  "rejectedToolNames": [
-    "unknown_tool"
-  ]
-}
+  "rejectedByPolicy": false,
+  "rejectedToolNames": []
+}

tests/node/chat-stream.test.js

@@ -58,7 +58,7 @@ test('boolDefaultTrue keeps false only when explicitly false', () => {
   assert.equal(boolDefaultTrue(undefined), true);
 });
 
-test('filterIncrementalToolCallDeltasByAllowed blocks unknown name and follow-up args', () => {
+test('filterIncrementalToolCallDeltasByAllowed keeps unknown name and follow-up args', () => {
   const seen = new Map();
   const filtered = filterIncrementalToolCallDeltasByAllowed(
     [
@@ -68,8 +68,11 @@ test('filterIncrementalToolCallDeltasByAllowed blocks unknown name and follow-up
     ['read_file'],
     seen,
   );
-  assert.deepEqual(filtered, []);
-  assert.equal(seen.get(0), '__blocked__');
+  assert.deepEqual(filtered, [
+    { index: 0, name: 'not_in_schema' },
+    { index: 0, arguments: '{"x":1}' },
+  ]);
+  assert.equal(seen.get(0), 'not_in_schema');
 });
 
 test('filterIncrementalToolCallDeltasByAllowed keeps allowed name and args', () => {