lisone/ds2api
1
0
Fork 0
mirror of https://github.com/CJackHwang/ds2api.git synced 2026-05-06 17:35:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: stop stripping _raw and _xml fields from tool call inputs to preserve raw parameter data

Browse Source
This commit is contained in:
CJACK
2026-04-05 18:33:15 +08:00
parent f2ad888de4
commit b8e9ca2028
2 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/util/toolcalls_parse.go
View File

@@ -158,10 +158,6 @@ func filterToolCallsDetailed(parsed []ParsedToolCall, availableToolNames []strin
}
if tc.Input == nil {
tc.Input = map[string]any{}
} else {
// Remove known hallucinated fields often generated by models trying to bridge XML and JSON
delete(tc.Input, "_raw")
delete(tc.Input, "_xml")
}
out = append(out, tc)
}

18
internal/util/toolcalls_test.go
View File

@@ -176,6 +176,24 @@ func TestParseToolCallsSupportsCanonicalXMLParametersJSON(t *testing.T) {
}
}
func TestParseToolCallsPreservesRawMalformedXMLParameters(t *testing.T) {
text := `<tool_call><tool_name>execute_command</tool_name><parameters>cd /root && git status</parameters></tool_call>`
calls := ParseToolCalls(text, []string{"execute_command"})
if len(calls) != 1 {
t.Fatalf("expected 1 call, got %#v", calls)
}
if calls[0].Name != "execute_command" {
t.Fatalf("expected tool name execute_command, got %q", calls[0].Name)
}
raw, ok := calls[0].Input["_raw"].(string)
if !ok {
t.Fatalf("expected raw argument tracking, got %#v", calls[0].Input)
}
if raw != "cd /root && git status" {
t.Fatalf("expected raw arguments to be preserved, got %q", raw)
}
}
func TestParseToolCallsSupportsXMLParametersJSONWithAmpersandCommand(t *testing.T) {
text := `<tool_calls><tool_call><tool_name>execute_command</tool_name><parameters>{"command":"sshpass -p 'xxx' ssh -o StrictHostKeyChecking=no -p 1111 root@111.111.111.111 'cd /root && git clone https://github.com/ericc-ch/copilot-api.git'","cwd":null,"timeout":null}</parameters></tool_call></tool_calls>`
calls := ParseToolCalls(text, []string{"execute_command"})