lisone/ds2api
1
0
Fork 0
mirror of https://github.com/CJackHwang/ds2api.git synced 2026-05-06 09:25:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #430 from NgoQuocViet2001/ai/openai-stream-empty-choices

Browse Source 
fix(openai): avoid empty choices stream heartbeat
This commit is contained in:
CJACK.
2026-05-05 22:24:21 +08:00
committed by GitHub
parent 4678a061d0 4315b424bf
commit d69b0658ea
2 changed files with 4 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/httpapi/openai/chat/chat_stream_runtime.go
View File

@@ -127,13 +127,7 @@ func (s *chatStreamRuntime) sendKeepAlive() {
return
}
_, _ = s.w.Write([]byte(": keep-alive\n\n"))
s.sendChunk(openaifmt.BuildChatStreamChunk(
s.completionID,
s.created,
s.model,
[]map[string]any{},
nil,
))
_ = s.rc.Flush()
}
func (s *chatStreamRuntime) sendChunk(v any) {

16
internal/httpapi/openai/chat/chat_stream_runtime_test.go
View File

@@ -10,7 +10,7 @@ import (
"ds2api/internal/promptcompat"
)
func TestChatStreamKeepAliveEmitsEmptyChoiceDataFrame(t *testing.T) {
func TestChatStreamKeepAliveUsesCommentOnly(t *testing.T) {
rec := httptest.NewRecorder()
runtime := newChatStreamRuntime(
rec,
@@ -40,18 +40,8 @@ func TestChatStreamKeepAliveEmitsEmptyChoiceDataFrame(t *testing.T) {
if done {
t.Fatalf("keep-alive must not emit [DONE], body=%q", body)
}
if len(frames) != 1 {
t.Fatalf("expected one data frame, got %d body=%q", len(frames), body)
}
if got := asString(frames[0]["id"]); got != "chatcmpl-test" {
t.Fatalf("expected completion id to be preserved, got %q", got)
}
if got := asString(frames[0]["object"]); got != "chat.completion.chunk" {
t.Fatalf("expected chat chunk object, got %q", got)
}
choices, _ := frames[0]["choices"].([]any)
if len(choices) != 0 {
t.Fatalf("expected empty choices heartbeat, got %#v", choices)
if len(frames) != 0 {
t.Fatalf("keep-alive must not emit JSON data frames, got %#v body=%q", frames, body)
}
}